[BEAM-6083] share parsing functions to parse time among SQL tests#7072
Merged
akedin merged 1 commit intoapache:masterfrom Nov 19, 2018
Merged
[BEAM-6083] share parsing functions to parse time among SQL tests#7072akedin merged 1 commit intoapache:masterfrom
akedin merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
Contributor
Author
|
run java postcommit |
amaliujia
force-pushed
the
rw_parse_time
branch
from
294fa9f to
3008f5a
Compare
Contributor
Author
|
run java postcommit |
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
closes apache#6826 respect transform values passed into collection.add
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing time parsing functions among SQL tests.
The benefits are:
new Datetime()way looks too long in IDE and makes code hard to read."SELECT DATE '2018-01-30'"), then that string can be copied to parsing functions for query result match (compared to write anew Datetime.Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)